lkml.org 
[lkml]   [2021]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 15/15] block: use bvec_kmap_local in bio_integrity_process
    Date
    Using local kmaps slightly reduces the chances to stray writes, and
    the bvec interface cleans up the code a little bit.

    Signed-off-by: Christoph Hellwig <hch@lst.de>
    Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
    ---
    block/bio-integrity.c | 14 ++++++--------
    1 file changed, 6 insertions(+), 8 deletions(-)

    diff --git a/block/bio-integrity.c b/block/bio-integrity.c
    index 4b4eb8964a6f..8f54d49dc500 100644
    --- a/block/bio-integrity.c
    +++ b/block/bio-integrity.c
    @@ -172,18 +172,16 @@ static blk_status_t bio_integrity_process(struct bio *bio,
    iter.prot_buf = prot_buf;

    __bio_for_each_segment(bv, bio, bviter, *proc_iter) {
    - void *kaddr = kmap_atomic(bv.bv_page);
    + void *kaddr = bvec_kmap_local(&bv);

    - iter.data_buf = kaddr + bv.bv_offset;
    + iter.data_buf = kaddr;
    iter.data_size = bv.bv_len;
    -
    ret = proc_fn(&iter);
    - if (ret) {
    - kunmap_atomic(kaddr);
    - return ret;
    - }
    + kunmap_local(kaddr);
    +
    + if (ret)
    + break;

    - kunmap_atomic(kaddr);
    }
    return ret;
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2021-07-27 08:27    [W:3.920 / U:0.988 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site