Messages in this thread | | | From | Michael Chan <> | Date | Tue, 27 Jul 2021 18:03:22 -0700 | Subject | Re: [PATCH 06/64] bnxt_en: Use struct_group_attr() for memcpy() region |
| |
On Tue, Jul 27, 2021 at 2:01 PM Kees Cook <keescook@chromium.org> wrote: > > In preparation for FORTIFY_SOURCE performing compile-time and run-time > field bounds checking for memcpy(), memmove(), and memset(), avoid > intentionally writing across neighboring fields. > > Use struct_group() around members queue_id, min_bw, max_bw, tsa, pri_lvl, > and bw_weight so they can be referenced together. This will allow memcpy() > and sizeof() to more easily reason about sizes, improve readability, > and avoid future warnings about writing beyond the end of queue_id. > > "pahole" shows no size nor member offset changes to struct bnxt_cos2bw_cfg. > "objdump -d" shows no meaningful object code changes (i.e. only source > line number induced differences and optimizations). > > Signed-off-by: Kees Cook <keescook@chromium.org>
Thanks. Reviewed-by: Michael Chan <michael.chan@broadcom.com> [unhandled content-type:application/pkcs7-signature] | |