Messages in this thread | | | Subject | Re: [PATCH v2] KEYS: trusted: fix use as module when CONFIG_TCG_TPM=m | From | Ahmad Fatoum <> | Date | Tue, 27 Jul 2021 06:24:49 +0200 |
| |
On 27.07.21 05:04, Jarkko Sakkinen wrote: >> Reported-by: Andreas Rammhold <andreas@rammhold.de> >> Fixes: 5d0682be3189 ("KEYS: trusted: Add generic trusted keys framework") >> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> > > Is it absolutely need to do all this *just* to fix the bug? > > For a pure bug fix the most essential thing is to be able the backport > it to stable kernels.
Not much happened in-between, so a backport should be trivial. I can provide these if needed.
> I don't really care at all about extra niceties ("it's now possible > stuff). > > This looks like a bug fix and improvements bundle into a single patch.
You can replace the #ifdefs with #if IS_REACHABLE in trusted_core.c to fix the intermediate breakage and then throw that away again to fix the remaining dependency of trusted keys on TCG_TPM.
If you prefer that, Andreas perhaps could respin his series with s/IS_ENABLED/IS_REACHABLE/?
Cheers, Ahmad
> > /Jarkko >
-- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
| |