lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/27] ALSA: hda/cs8409: Add support for dolphin
Hi Vitaly,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on sound/for-next]
[also build test WARNING on v5.14-rc3 next-20210726]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Vitaly-Rodionov/ALSA-hda-cirrus-Split-generic-cirrus-HDA-codecs-and-CS8490-bridge-into-separate-modules/20210727-022225
base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: ia64-randconfig-s031-20210726 (attached as .config)
compiler: ia64-linux-gcc (GCC) 10.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://github.com/0day-ci/linux/commit/25eb89e84220ba0be273351c13cd6d92fc4910b0
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vitaly-Rodionov/ALSA-hda-cirrus-Split-generic-cirrus-HDA-codecs-and-CS8490-bridge-into-separate-modules/20210727-022225
git checkout 25eb89e84220ba0be273351c13cd6d92fc4910b0
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=ia64 SHELL=/bin/bash sound/pci/hda/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> sound/pci/hda/patch_cs8409.c:1061:59: sparse: sparse: Using plain integer as NULL pointer

vim +1061 sound/pci/hda/patch_cs8409.c

1029
1030 void dolphin_fixups(struct hda_codec *codec, const struct hda_fixup *fix, int action)
1031 {
1032 struct cs8409_spec *spec = codec->spec;
1033 struct snd_kcontrol_new *kctrl;
1034 int i;
1035
1036 switch (action) {
1037 case HDA_FIXUP_ACT_PRE_PROBE:
1038 snd_hda_add_verbs(codec, dolphin_init_verbs);
1039 /* verb exec op override */
1040 spec->exec_verb = codec->core.exec_verb;
1041 codec->core.exec_verb = dolphin_exec_verb;
1042
1043 spec->scodecs[CS8409_CODEC0] = &dolphin_cs42l42_0;
1044 spec->scodecs[CS8409_CODEC0]->codec = codec;
1045 spec->scodecs[CS8409_CODEC1] = &dolphin_cs42l42_1;
1046 spec->scodecs[CS8409_CODEC1]->codec = codec;
1047 spec->num_scodecs = 2;
1048
1049 codec->patch_ops = cs8409_dolphin_patch_ops;
1050
1051 /* GPIO 1,5 out, 0,4 in */
1052 spec->gpio_dir = spec->scodecs[CS8409_CODEC0]->reset_gpio |
1053 spec->scodecs[CS8409_CODEC1]->reset_gpio;
1054 spec->gpio_data = 0;
1055 spec->gpio_mask = 0x03f;
1056
1057 /* Basic initial sequence for specific hw configuration */
1058 snd_hda_sequence_write(codec, dolphin_init_verbs);
1059
1060 snd_hda_jack_add_kctl(codec, DOLPHIN_LO_PIN_NID, "Line Out", true,
> 1061 SND_JACK_HEADPHONE, 0);
1062
1063 cs8409_fix_caps(codec, DOLPHIN_HP_PIN_NID);
1064 cs8409_fix_caps(codec, DOLPHIN_LO_PIN_NID);
1065 cs8409_fix_caps(codec, DOLPHIN_AMIC_PIN_NID);
1066
1067 break;
1068 case HDA_FIXUP_ACT_PROBE:
1069 snd_hda_gen_add_kctl(&spec->gen, "Headphone Playback Volume",
1070 &cs42l42_dac_volume_mixer);
1071 snd_hda_gen_add_kctl(&spec->gen, "Mic Capture Volume", &cs42l42_adc_volume_mixer);
1072 kctrl = snd_hda_gen_add_kctl(&spec->gen, "Line Out Playback Volume",
1073 &cs42l42_dac_volume_mixer);
1074 /* Update Line Out kcontrol template */
1075 kctrl->private_value = HDA_COMPOSE_AMP_VAL_OFS(DOLPHIN_HP_PIN_NID, 3, CS8409_CODEC1,
1076 HDA_OUTPUT, CS42L42_VOL_DAC) | HDA_AMP_VAL_MIN_MUTE;
1077 cs8409_enable_ur(codec, 0);
1078 dolphin_hw_init(codec);
1079 snd_hda_codec_set_name(codec, "CS8409/CS42L42");
1080 break;
1081 case HDA_FIXUP_ACT_INIT:
1082 dolphin_hw_init(codec);
1083 fallthrough;
1084 case HDA_FIXUP_ACT_BUILD:
1085 /* Run jack auto detect first time on boot
1086 * after controls have been added, to check if jack has
1087 * been already plugged in.
1088 * Run immediately after init.
1089 */
1090 for (i = 0; i < spec->num_scodecs; i++) {
1091 cs42l42_run_jack_detect(spec->scodecs[i]);
1092 usleep_range(100000, 150000);
1093 }
1094
1095 break;
1096 default:
1097 break;
1098 }
1099 }
1100

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-07-27 02:26    [W:0.302 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site