Messages in this thread | | | Date | Mon, 26 Jul 2021 20:43:28 +0200 | From | Joerg Roedel <> | Subject | Re: [PATCH 16/23] iommu/arm-smmu: Prepare for multiple DMA domain types |
| |
On Mon, Jul 26, 2021 at 02:09:00PM +0100, Robin Murphy wrote: > Ha, I had exactly that at one point, except I think in the order of > iommu_is_dma_domain() :)
That name is fine too :)
> The end result didn't seem to give enough extra clarity to justify the > header churn for me, but I'm happy to be wrong about that if you prefer.
Developers look more into the code than into headers, so I think the header churn is worth it to improve code readability. But we can do that on-top of these changes in an extra patch-set which also introduces helpers for other domain types (if it is worth it).
Regards,
Jörg
| |