lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] nvme: Add abrupt shutdown support
Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pavel-linux-leds/for-next]
[also build test ERROR on linus/master v5.14-rc3 next-20210723]
[cannot apply to linux-nvme/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/shiva-linuxworks-gmail-com/Abrupt-Shutdown-for-NVMe-SSD/20210726-212459
base: git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git for-next
config: nios2-randconfig-p002-20210726 (attached as .config)
compiler: nios2-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/929817804ad19d2760e156c539dbec82638c35c3
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review shiva-linuxworks-gmail-com/Abrupt-Shutdown-for-NVMe-SSD/20210726-212459
git checkout 929817804ad19d2760e156c539dbec82638c35c3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=nios2

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

drivers/nvme/host/core.c: In function 'nvme_shutdown_ctrl':
>> drivers/nvme/host/core.c:2164:6: error: implicit declaration of function 'pm_power_loss_imminent' [-Werror=implicit-function-declaration]
2164 | if (pm_power_loss_imminent())
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors


vim +/pm_power_loss_imminent +2164 drivers/nvme/host/core.c

2155
2156 int nvme_shutdown_ctrl(struct nvme_ctrl *ctrl)
2157 {
2158 unsigned long timeout = jiffies + (ctrl->shutdown_timeout * HZ);
2159 u32 csts;
2160 int ret;
2161
2162 ctrl->ctrl_config &= ~NVME_CC_SHN_MASK;
2163
> 2164 if (pm_power_loss_imminent())
2165 ctrl->ctrl_config |= NVME_CC_SHN_ABRUPT;
2166 else
2167 ctrl->ctrl_config |= NVME_CC_SHN_NORMAL;
2168
2169 ret = ctrl->ops->reg_write32(ctrl, NVME_REG_CC, ctrl->ctrl_config);
2170 if (ret)
2171 return ret;
2172
2173 while ((ret = ctrl->ops->reg_read32(ctrl, NVME_REG_CSTS, &csts)) == 0) {
2174 if ((csts & NVME_CSTS_SHST_MASK) == NVME_CSTS_SHST_CMPLT)
2175 break;
2176
2177 msleep(100);
2178 if (fatal_signal_pending(current))
2179 return -EINTR;
2180 if (time_after(jiffies, timeout)) {
2181 dev_err(ctrl->device,
2182 "Device shutdown incomplete; abort shutdown\n");
2183 return -ENODEV;
2184 }
2185 }
2186
2187 return ret;
2188 }
2189 EXPORT_SYMBOL_GPL(nvme_shutdown_ctrl);
2190

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2021-07-26 18:48    [W:0.083 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site