lkml.org 
[lkml]   [2021]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 054/167] ASoC: rt5631: Fix regcache sync errors on resume
    Date
    From: Maxim Schwalm <maxim.schwalm@gmail.com>

    [ Upstream commit c71f78a662611fe2c67f3155da19b0eff0f29762 ]

    The ALC5631 does not like multi-write accesses, avoid them. This fixes:

    rt5631 4-001a: Unable to sync registers 0x3a-0x3c. -121

    errors on resume from suspend (and all registers after the registers in
    the error not being synced).

    Inspired by commit 2d30e9494f1e ("ASoC: rt5651: Fix regcache sync errors
    on resume") from Hans de Geode, which fixed the same errors on ALC5651.

    Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com>
    Link: https://lore.kernel.org/r/20210712005011.28536-1-digetx@gmail.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/rt5631.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/sound/soc/codecs/rt5631.c b/sound/soc/codecs/rt5631.c
    index 653da3eaf355..86d58d0df057 100644
    --- a/sound/soc/codecs/rt5631.c
    +++ b/sound/soc/codecs/rt5631.c
    @@ -1695,6 +1695,8 @@ static const struct regmap_config rt5631_regmap_config = {
    .reg_defaults = rt5631_reg,
    .num_reg_defaults = ARRAY_SIZE(rt5631_reg),
    .cache_type = REGCACHE_RBTREE,
    + .use_single_read = true,
    + .use_single_write = true,
    };

    static int rt5631_i2c_probe(struct i2c_client *i2c,
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-26 18:18    [W:2.646 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site