Messages in this thread | | | From | Jernej Škrabec <> | Subject | Re: [PATCH v8 03/11] rtc: sun6i: Fix time overflow handling | Date | Sun, 25 Jul 2021 07:44:05 +0200 |
| |
Hi Andre!
Dne petek, 23. julij 2021 ob 17:38:30 CEST je Andre Przywara napisal(a): > Using "unsigned long" for UNIX timestamps is never a good idea, and > comparing the value of such a variable against U32_MAX does not do > anything useful on 32-bit systems. > > Use the proper time64_t type when dealing with timestamps, and avoid > cutting down the time range unnecessarily. This also fixes the flawed > check for the alarm time being too far into the future. > > The check for this condition is actually somewhat theoretical, as the > RTC counts till 2033 only anyways, and 2^32 seconds from now is not > before the year 2157 - at which point I hope nobody will be using this > hardware anymore. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > drivers/rtc/rtc-sun6i.c | 14 +++++--------- > 1 file changed, 5 insertions(+), 9 deletions(-)
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards, Jernej
| |