lkml.org 
[lkml]   [2021]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] fpga: versal-fpga: Remove empty functions
Date
Since the core framework now wraps the functions, ensuring
drives only have to implement functions that do something,
drop the now no longer required callbacks for state and
write_complete.

Signed-off-by: Moritz Fischer <mdf@kernel.org>
---

Hi Greg,

This needs to wait for the earlier pull request [1] that introduces the
wrapper functions, allowing drivers to drop the empty ones.

Unfortunately this sort of got of sync with the versal patches getting
picked up before the wrapper changes went in.


- Moritz

[1] https://lore.kernel.org/linux-fpga/YP4kHpn7CDzCYrbU@epycbox.lan/
---
drivers/fpga/versal-fpga.c | 13 -------------
1 file changed, 13 deletions(-)

diff --git a/drivers/fpga/versal-fpga.c b/drivers/fpga/versal-fpga.c
index 1bd312a31b23..5b0dda304bd2 100644
--- a/drivers/fpga/versal-fpga.c
+++ b/drivers/fpga/versal-fpga.c
@@ -37,22 +37,9 @@ static int versal_fpga_ops_write(struct fpga_manager *mgr,
return ret;
}

-static int versal_fpga_ops_write_complete(struct fpga_manager *mgr,
- struct fpga_image_info *info)
-{
- return 0;
-}
-
-static enum fpga_mgr_states versal_fpga_ops_state(struct fpga_manager *mgr)
-{
- return FPGA_MGR_STATE_UNKNOWN;
-}
-
static const struct fpga_manager_ops versal_fpga_ops = {
- .state = versal_fpga_ops_state,
.write_init = versal_fpga_ops_write_init,
.write = versal_fpga_ops_write,
- .write_complete = versal_fpga_ops_write_complete,
};

static int versal_fpga_probe(struct platform_device *pdev)
--
2.32.0
\
 
 \ /
  Last update: 2021-07-26 05:09    [W:0.033 / U:0.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site