Messages in this thread | | | Subject | Re: [PATCH 09/18] staging: rtl8188eu: remove unused _HAL_INTF_C_ define | From | Christophe JAILLET <> | Date | Sun, 25 Jul 2021 18:45:39 +0200 |
| |
Le 25/07/2021 à 18:38, Greg Kroah-Hartman a écrit : > On Sun, Jul 25, 2021 at 06:32:10PM +0200, Christophe JAILLET wrote: >> Le 25/07/2021 à 17:58, Martin Kaiser a écrit : >>> This define can be removed. >>> >>> Signed-off-by: Martin Kaiser <martin@kaiser.cx> >>> --- >>> drivers/staging/rtl8188eu/hal/hal_intf.c | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/drivers/staging/rtl8188eu/hal/hal_intf.c b/drivers/staging/rtl8188eu/hal/hal_intf.c >>> index f09620c54e69..3e132e00c81c 100644 >>> --- a/drivers/staging/rtl8188eu/hal/hal_intf.c >>> +++ b/drivers/staging/rtl8188eu/hal/hal_intf.c >>> @@ -5,7 +5,6 @@ >>> * >>> ******************************************************************************/ >>> -#define _HAL_INTF_C_ >>> #include <hal_intf.h> >>> uint rtw_hal_init(struct adapter *adapt) >>> >> >> Hi, >> >> This one looks like an include guard. >> >> #ifndef _HAL_INTF_C_ >> #define _HAL_INTF_C_ >> ... >> #endif /* _HAL_INTF_C_ */ >> >> ? > > But it really does not do anything, so should be dropped as the patch > does. > > Unless I am reading the code wrong? > > greg k-h >
+1, I thought it was a .h file.
Sorry for the noise.
CJ
| |