Messages in this thread | | | Date | Sun, 25 Jul 2021 18:30:39 +0200 | From | Marc Kleine-Budde <> | Subject | Re: [PATCH] net: can: add missing urb->transfer_dma initialization |
| |
On 25.07.2021 22:27:37, Yasushi SHOJI wrote: > Hi Pavel, > > I've tested this patch on top of v5.14-rc2. All good. > > Tested-by: Yasushi SHOJI <yashi@spacecubics.com> > > Some nitpicks. > > On Sun, Jul 25, 2021 at 7:36 PM Pavel Skripkin <paskripkin@gmail.com> wrote: > > > > Yasushi reported, that his Microchip CAN Analyzer stopped working since > > commit 91c02557174b ("can: mcba_usb: fix memory leak in mcba_usb"). > > The problem was in missing urb->transfer_dma initialization. > > > > In my previous patch to this driver I refactored mcba_usb_start() code to > > avoid leaking usb coherent buffers. To achive it, I passed local stack > > achieve > > > variable to usb_alloc_coherent() and then saved it to private array to > > correctly free all coherent buffers on ->close() call. But I forgot to > > inialize urb->transfer_dma with variable passed to usb_alloc_coherent(). > > initialize
Fixed while applying.
Thanks, Marc
-- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | [unhandled content-type:application/pgp-signature] | |