lkml.org 
[lkml]   [2021]   [Jul]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RT 5/8] sched: Fix affine_move_task() self-concurrency
Hi!

> 5.10.47-rt46-rc1 stable review patch.
> If anyone has any objections, please let me know.
>
> Add set_affinity_pending::stop_pending, to indicate if a stopper is in
> progress.
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 9cbe12d8c5bd..20588a59300d 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1900,6 +1900,7 @@ struct migration_arg {
>
> struct set_affinity_pending {
> refcount_t refs;
> + unsigned int stop_pending;
> struct completion done;
> struct cpu_stop_work stop_work;
> struct migration_arg arg;

For better readability, this should be bool, AFAICT.

> * and have the stopper function handle it all race-free.
> */
> + stop_pending = pending->stop_pending;
> + if (!stop_pending)
> + pending->stop_pending = true;
>
...because it is used as bool.

Pavel

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

\
 
 \ /
  Last update: 2021-07-25 07:04    [W:0.065 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site