lkml.org 
[lkml]   [2021]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[Resend PATCH] driver: zram: fix wrong counting on pages_store
    Subject: [PATCH] driver: zram: fix wrong counting on pages_store
    Date: Tue, 20 Jul 2021 14:47:38 +0800
    Message-Id: <1626763658-27748-1-git-send-email-huangzhaoyang@gmail.com>
    X-Mailer: git-send-email 1.7.9.5

    From: Zhaoyang Huang <zhaoyang.huang@unisoc.com>

    It makes the statistic confused when counting pages_store in during writeback.
    pages_store should just reflect the swapped pages on ZRAM, while bd_writes be
    responsible for writeback things.

    Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
    ---
    drivers/block/zram/zram_drv.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
    index cf8deec..6bdaa9d 100644
    --- a/drivers/block/zram/zram_drv.c
    +++ b/drivers/block/zram/zram_drv.c
    @@ -765,7 +765,6 @@ static ssize_t writeback_store(struct device *dev,
    zram_set_flag(zram, index, ZRAM_WB);
    zram_set_element(zram, index, blk_idx);
    blk_idx = 0;
    - atomic64_inc(&zram->stats.pages_stored);
    spin_lock(&zram->wb_limit_lock);
    if (zram->wb_limit_enable && zram->bd_wb_limit > 0)
    zram->bd_wb_limit -= 1UL << (PAGE_SHIFT - 12);
    --
    1.9.1
    \
     
     \ /
      Last update: 2021-07-25 03:20    [W:2.659 / U:0.096 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site