Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 24 Jul 2021 23:21:04 +0300 | Subject | Re: [PATCH v2 1/3] staging/fbtft: Remove all strcpy() uses |
| |
On Sat, Jul 24, 2021 at 7:05 PM Len Baker <len.baker@gmx.com> wrote: > > strcpy() performs no bounds checking on the destination buffer. This > could result in linear overflows beyond the end of the buffer, leading > to all kinds of misbehaviors. The safe replacement is strscpy() but in > this case it is simpler to use the "%*ph" format specifier.
...
> - char msg[128];
128 / 4 = 32. So, this buffer is enough to debug print only up to 32 bytes. Hence %*ph replacement won't cut output earlier than requested.
...
> + for (j = i + 1; par->init_sequence[j] >= 0; j++);
Why is i + 1 initial for the j? You may rather access the 'i + 1 + j'th element in the array...
...
> + par->init_sequence[i], j - i - 1,
...and get rid of the ' - i -1' part here.
-- With Best Regards, Andy Shevchenko
| |