Messages in this thread | | | From | Geert Uytterhoeven <> | Date | Sat, 24 Jul 2021 20:01:53 +0200 | Subject | Re: [PATCH v2 3/3] staging/fbtft: Fix braces coding style |
| |
Hi Len,
On Sat, Jul 24, 2021 at 7:44 PM Len Baker <len.baker@gmx.com> wrote: > Add braces to the "for" loop and remove braces from the "if" statement. > This way the kernel coding style is followed. > > Signed-off-by: Len Baker <len.baker@gmx.com>
Thanks for your patch!
> --- a/drivers/staging/fbtft/fbtft-core.c > +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -1016,10 +1018,9 @@ int fbtft_init_display(struct fbtft_par *par) > > i = 0; > while (i < FBTFT_MAX_INIT_SEQUENCE) { > - if (par->init_sequence[i] == -3) { > - /* done */ > - return 0; > - }
These braces should not be removed, due to the presence of the comment.
> + if (par->init_sequence[i] == -3) > + return 0; /* done */ > + > if (par->init_sequence[i] >= 0) { > dev_err(par->info->device, > "missing delimiter at position %d\n", i);
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |