lkml.org 
[lkml]   [2021]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 0/3] iio: vcnl3020: add periodic mode, threshold options
On Thu, 22 Jul 2021 18:44:17 +0300
Ivan Mikhaylov <i.mikhaylov@yadro.com> wrote:

> Add periodic mode enablement, high/low threshold options.
>
> Changes from v1:
> 1. Remove changes for hwmon driver and changes affecting
> vcnl3020 data structure.
> 2. Add enable/disable periodic mode functions.
>
> Changes from v2:
> 1. Minor fixes from Jonathan's comments.
>
> Changes from v3:
> 1. add DMA safe buffer in vcnl3020_data and use it on bulk_read/write
> calls
> 2. put vcnl3020_is_in_periodic_mode in vcnl3020_measure_proximity and
> vcnl3020_write_proxy_samp_freq
> 3. add mutex instead of iio_claim in vcnl3020_write_proxy_samp_freq
> 4. out_mutex -> err_unlock
>
> Changes from v4:
> 1. split into 3 patches - DMA safe buffer, periodic mode, change
> iio_claim/release on mutex.
> 2. add dev_err for regmap_read/write

Hi Ivan,

Given I only wanted some trivial changes in patch 2, I've made those whilst applying
rather that wasting either of our time with a v6. Please take a quick look to check
I didn't mess anything up!

Applied to the togreg branch of iio.git on kernel.org and pushed out as testing for
0-day to poke at it and see what it can find,

Thanks,

Jonathan

>
> Ivan Mikhaylov (3):
> iio: proximity: vcnl3020: add DMA safe buffer
> iio: proximity: vcnl3020: add periodic mode
> iio: proximity: vcnl3020: remove iio_claim/release_direct
>
> drivers/iio/proximity/vcnl3020.c | 354 +++++++++++++++++++++++++++++--
> 1 file changed, 338 insertions(+), 16 deletions(-)
>

\
 
 \ /
  Last update: 2021-07-24 17:08    [W:0.188 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site