Messages in this thread | | | From | Masahiro Yamada <> | Date | Sat, 24 Jul 2021 22:56:25 +0900 | Subject | Re: [PATCH] scripts: merge_config: add strict mode to fail upon any redefinition |
| |
On Thu, Jul 22, 2021 at 7:13 PM Lee Jones <lee.jones@linaro.org> wrote: > > Masahiro, > > On Fri, 21 May 2021 at 10:29, Lee Jones <lee.jones@linaro.org> wrote: >> >> On Wed, 2 Dec 2020 at 15:13, Matthias Maennich <maennich@google.com> wrote: >>> >>> When merging configuration fragments, it might be of interest to >>> identify mismatches (redefinitions) programmatically. Hence add the >>> option -s (strict mode) to instruct merge_config.sh to bail out in >>> case any redefinition has been detected. >>> >>> With strict mode, warnings are emitted as before, but the script >>> terminates with rc=1. If -y is set to define "builtin having >>> precedence over modules", fragments are still allowed to set =m (while >>> the base config has =y). Strict mode will tolerate that as demotions >>> from =y to =m are ignored when setting -y. >>> >>> Cc: Masahiro Yamada <masahiroy@kernel.org> >>> Signed-off-by: Matthias Maennich <maennich@google.com> >>> --- >>> scripts/kconfig/merge_config.sh | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >> >> >> Reviewed-by: Lee Jones <lee.jones@linaro.org> > > > Any idea what's holding this up please?
Simply because I hate this script.
merge_config.sh itself is a bad hack. I do not like to extend it further.
Not only this one. I saw more people with "hey, I came up with a new option for merge_config.sh" to do whatever they like to do.
However, it might be too late anyway.
So, I can merge this patch if people believe it is useful.
-- Best Regards Masahiro Yamada
| |