Messages in this thread | | | Date | Fri, 23 Jul 2021 13:29:45 -0700 | From | Eric Biggers <> | Subject | Re: [f2fs-dev] [PATCH v3] f2fs: change fiemap way in printing compression chunk |
| |
On Fri, Jul 23, 2021 at 12:49:28AM -0700, Daeho Jeong wrote: > From: Daeho Jeong <daehojeong@google.com> > > When we print out a discontinuous compression chunk, it shows like a > continuous chunk now. To show it more correctly, I've changed the way of > printing fiemap info like below. Plus, eliminated NEW_ADDR(-1) in fiemap > info, since it is not in fiemap user api manual. > > Let's assume 16KB compression cluster. > > <before> > Logical Physical Length Flags > 0: 0000000000000000 00000002c091f000 0000000000004000 1008 > 1: 0000000000004000 00000002c0920000 0000000000004000 1008 > ... > 9: 0000000000034000 0000000f8c623000 0000000000004000 1008 > 10: 0000000000038000 000000101a6eb000 0000000000004000 1008 > > <after> > 0: 0000000000000000 00000002c091f000 0000000000004000 1008 > 1: 0000000000004000 00000002c0920000 0000000000004000 1008 > ... > 9: 0000000000034000 0000000f8c623000 0000000000001000 1008 > 10: 0000000000035000 000000101a6ea000 0000000000003000 1008 > 11: 0000000000038000 000000101a6eb000 0000000000002000 1008 > 12: 000000000003a000 00000002c3544000 0000000000002000 1008 > > Flags > 0x1000 => FIEMAP_EXTENT_MERGED > 0x0008 => FIEMAP_EXTENT_ENCODED > > Signed-off-by: Daeho Jeong <daehojeong@google.com> > > --- > v3: fix the missing last extent flag issue > v2: changed the print format > --- > fs/f2fs/data.c | 75 ++++++++++++++++++++++++++++---------------------- > 1 file changed, 42 insertions(+), 33 deletions(-)
I can't understand the code in f2fs_fiemap(), but I tested that my two compression+encryption tests (xfstest f2fs/002 and Android vts_kernel_encryption_test) pass reliably when this patch is applied.
Tested-by: Eric Biggers <ebiggers@google.com>
- Eric
| |