lkml.org 
[lkml]   [2021]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH AUTOSEL 4.19 31/39] arm64: dts: ls208xa: remove bus-num from dspi node
    Hi!

    > [ Upstream commit 8240c972c1798ea013cbb407722295fc826b3584 ]
    >
    > On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module
    > then its probe fails with the following warning:
    >
    > [ 10.471363] couldn't get idr
    > [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0
    > ...
    > [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr
    > [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16
    >
    > Reason for the failure is that bus-num property is set for dspi node.
    > However, bus-num property is not set for the qspi node. If probe for
    > spi-fsl-qspi happens first then id 0 is dynamically allocated to it.
    > Call to spi_register_controller() from spi-fsl-dspi driver then fails.
    > Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property
    > optional") bus-num property is optional. Remove bus-num property from
    > dspi node to fix the issue.

    According to changelog this depends on 29d2daf2c33c. Than one is
    present in 5.10-stable, but not in 4.19-stable, AFAICT.

    Best regards,
    Pavel

    > +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
    > @@ -479,7 +479,6 @@ dspi: spi@2100000 {
    > clocks = <&clockgen 4 3>;
    > clock-names = "dspi";
    > spi-num-chipselects = <5>;
    > - bus-num = <0>;
    > };
    >
    > esdhc: esdhc@2140000 {

    --
    DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
    HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2021-07-23 22:11    [W:4.067 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site