lkml.org 
[lkml]   [2021]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: pm8941-pwrkey - fix comma vs semicolon issue
On Fri, Jul 23, 2021 at 07:43:52PM +0000, Stephen Boyd wrote:
> Quoting Dmitry Torokhov (2021-07-23 12:39:02)
> > There is absolutely no reason to use comma operator in this code, 2
> > separate statements make much more sense.
> >
> > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > ---
>
> Fixes: 2fcbda9a822d ("Input: pm8941-pwrkey - add support for PMK8350
> PON_HLOS PMIC peripheral")

It actually predates this patch and also not really a fix as the
original code ends up working properly, but looks weird.

> Reviewed-by: Stephen Boyd <swboyd@chromium.org>

Thanks!

--
Dmitry

\
 
 \ /
  Last update: 2021-07-23 21:53    [W:0.049 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site