lkml.org 
[lkml]   [2021]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v2 19/21] x86/amd_gart: don't set failed sg dma_address to DMA_MAPPING_ERROR
    Setting the ->dma_address to DMA_MAPPING_ERROR is not part of
    the ->map_sg calling convention, so remove it.

    Link: https://lore.kernel.org/linux-mips/20210716063241.GC13345@lst.de/
    Suggested-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: Niklas Schnelle <schnelle@linux.ibm.com>
    Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    Cc: Michael Ellerman <mpe@ellerman.id.au>
    ---
    arch/x86/kernel/amd_gart_64.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/arch/x86/kernel/amd_gart_64.c b/arch/x86/kernel/amd_gart_64.c
    index 46aea9a4f26b..ed837383de5c 100644
    --- a/arch/x86/kernel/amd_gart_64.c
    +++ b/arch/x86/kernel/amd_gart_64.c
    @@ -458,8 +458,6 @@ static int gart_map_sg(struct device *dev, struct scatterlist *sg, int nents,
    panic("dma_map_sg: overflow on %lu pages\n", pages);

    iommu_full(dev, pages << PAGE_SHIFT, dir);
    - for_each_sg(sg, s, nents, i)
    - s->dma_address = DMA_MAPPING_ERROR;
    return ret;
    }

    --
    2.20.1
    \
     
     \ /
      Last update: 2021-07-23 19:51    [W:3.996 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site