lkml.org 
[lkml]   [2021]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging/rtl8192e: Remove all strcpy() uses in favor of strscpy()
Hi,

On Mon, Jul 19, 2021 at 08:43:45AM +0300, Dan Carpenter wrote:
> On Sun, Jul 18, 2021 at 11:06:36AM +0200, Len Baker wrote:
> > diff --git a/drivers/staging/rtl8192e/rtllib_softmac_wx.c b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > index f89799d43b1b..5968407c646d 100644
> > --- a/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > +++ b/drivers/staging/rtl8192e/rtllib_softmac_wx.c
> > @@ -543,7 +543,7 @@ int rtllib_wx_get_name(struct rtllib_device *ieee,
> > struct iw_request_info *info,
> > union iwreq_data *wrqu, char *extra)
> > {
> > - strcpy(wrqu->name, "802.11");
> > + strscpy(wrqu->name, "802.11", sizeof(wrqu->name));
> >
> > if (ieee->modulation & RTLLIB_CCK_MODULATION)
> > strcat(wrqu->name, "b");
>
> This patch is just about silencing inferior static analysis tools,
> right? Most checkers can figure out the size of the array and verify
> that it has space for "802.11". Probably it's only raw grep which
> can't.
>
> It doesn't make sense to me that we have strscpy() followed by strcat.
> So let's fix both.

Ok, I will send a v2 for review. Thanks for the feedback.

>
> regards,
> dan carpenter

Regards,
Len

\
 
 \ /
  Last update: 2021-07-23 18:33    [W:0.041 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site