Messages in this thread | | | From | Linus Walleij <> | Date | Fri, 23 Jul 2021 17:42:46 +0200 | Subject | Re: [PATCH v2] pinctrl: mediatek: Fix fallback behavior for bias_set_combo |
| |
Hi Hsin-Yi,
On Thu, Jul 1, 2021 at 10:10 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote: > > Some pin doesn't support PUPD register, if it fails and fallbacks with > bias_set_combo case, it will call mtk_pinconf_bias_set_pupd_r1_r0() to > modify the PUPD pin again. > > Since the general bias set are either PU/PD or PULLSEL/PULLEN, try > bias_set or bias_set_rev1 for the other fallback case. If the pin > doesn't support neither PU/PD nor PULLSEL/PULLEN, it will return > -ENOTSUPP. > > Fixes: 81bd1579b43e ("pinctrl: mediatek: Fix fallback call path") > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org> > --- > v2: fix v1 comments
Thanks for fixing this up so nicely, great work. Patch applied for fixes!
Yours, Linus Walleij
| |