Messages in this thread | | | Date | Fri, 23 Jul 2021 16:05:29 +0100 | From | Matthew Wilcox <> | Subject | Re: [PATCH v6] iomap: support tail packing inline read |
| |
On Thu, Jul 22, 2021 at 07:39:47AM +0200, Christoph Hellwig wrote: > @@ -675,7 +676,7 @@ static size_t iomap_write_end_inline(struct inode *inode, struct page *page, > > flush_dcache_page(page); > addr = kmap_atomic(page); > - memcpy(iomap->inline_data + pos, addr + pos, copied); > + memcpy(iomap_inline_buf(iomap, pos), addr + pos, copied);
This is wrong; pos can be > PAGE_SIZE, so this needs to be addr + offset_in_page(pos).
| |