Messages in this thread | | | Date | Fri, 23 Jul 2021 09:24:14 -0500 | From | Bjorn Andersson <> | Subject | Re: [PATCH] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module |
| |
On Wed 21 Jul 16:07 CDT 2021, Saravana Kannan wrote:
> On Wed, Jul 21, 2021 at 1:23 PM Bjorn Andersson > <bjorn.andersson@linaro.org> wrote: > > > > On Wed 21 Jul 13:00 CDT 2021, Saravana Kannan wrote: > > > > > On Wed, Jul 21, 2021 at 10:24 AM John Stultz <john.stultz@linaro.org> wrote: > > > > > > > > On Wed, Jul 21, 2021 at 4:54 AM Greg Kroah-Hartman > > > > <gregkh@linuxfoundation.org> wrote: > > > > > > > > > > On Wed, Jul 07, 2021 at 04:53:20AM +0000, John Stultz wrote: > > > > > > Allow the qcom_scm driver to be loadable as a permenent module. > > > > > > > > > > This feels like a regression, it should be allowed to be a module. > > > > > > > > I'm sorry, I'm not sure I'm following you, Greg. This patch is trying > > > > to enable the driver to be able to be loaded as a module. > > > > > > I think the mix up might be that Greg mentally read "permanent module" > > > as "builtin"? > > > > > > "permanent module" is just something that can't be unloaded once it's > > > loaded. It's not "builtin". > > > > > > > Afaict there's nothing in this patch that makes it more or less > > permanent. > > The lack of a module_exit() makes it a permanent module. If you do > lsmod, it'll mark this as "[permanent]". >
Cool, I didn't know that.
Thanks, Bjorn
| |