Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 22 Jul 2021 12:28:36 +0200 | Subject | Re: [PATCH V2 1/5] dt-bindings: virtio: Add binding for virtio devices |
| |
On Thu, Jul 22, 2021 at 11:57 AM Viresh Kumar <viresh.kumar@linaro.org> wrote: > > Allow virtio device sub-nodes to be added to the virtio mmio or pci > nodes. The compatible property for virtio device must be of format > "virtio,<DID>", where DID is virtio device ID in hexadecimal format. > > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Looks good to me overall. One question would be for the exact format of the 'compatible' string. After seeing this version, I would slightly prefer "virtio,device22" over "virtio,22". I think in the previous version we had mentioned both, but not actually decided on which one to use.
Arnd
| |