Messages in this thread | | | Date | Thu, 22 Jul 2021 18:24:48 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH net-next v6 4/6] net: socket: remove register_gifconf |
| |
On Thu, Jul 22, 2021 at 04:29:01PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > Since dynamic registration of the gifconf() helper is only used for > IPv4, and this can not be in a loadable module, this can be simplified > noticeably by turning it into a direct function call as a preparation > for cleaning up the compat handling.
I'd maybe mention that ipv4 must be built-in as that is the bit required for all the above to make sense.
Otherwise looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |