Messages in this thread | | | Date | Thu, 22 Jul 2021 17:24:04 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [PATCH v6 2/3] PCI: dwc: Add Qualcomm PCIe Endpoint controller driver |
| |
On Wed, Jul 14, 2021 at 02:15:09PM -0500, Bjorn Helgaas wrote: > Can you use the driver name for *this* driver in the subject instead > of "dwc"? Then we'll be able to identify changes related to this > driver easily in the "git log --oneline" output. >
Okay sure. I usually do that for the drivers that got merged but don't have any issues with driver prefix while under review.
> I'm not sure what that name should be -- you have the PCIE_QCOM_EP > config symbol and "qcom-pcie-ep" as the driver.name. Both seem > possibly a little too generic. We already have a "qcom" driver > (drivers/pci/controller/dwc/pcie-qcom.c). Is this for the same > hardware in endpoint mode? >
Yes
> Will this driver support every endpoint device from Qualcomm, even > future ones? People often use a model or codename here (xgene, > aardvark, armada, tegra, etc). But I guess you can always use > something more specific for future drivers if/when Qualcomm produces > something that requires a different driver. >
Since pcie-qcom.c supports most of the RC IPs in recent SoCs, I can assure that this driver can handle all EPs.
> On Wed, Jul 14, 2021 at 02:03:15PM +0530, Manivannan Sadhasivam wrote: > > Add driver support for Qualcomm PCIe Endpoint controller driver based on > > the Designware core with added Qualcomm specific wrapper around the > > core. The driver support is very basic such that it supports only > > enumeration, PCIe read/write, and MSI. There is no ASPM and PM support > > for now but these will be added later. > > > > The driver is capable of using the PERST# and WAKE# side-band GPIOs for > > operation and written on top of the DWC PCI framework. > >
[...]
> > +static int qcom_pcie_establish_link(struct dw_pcie *pci) > > +{ > > This is much more complicated than existing *_pcie_establish_link() > functions. Are other drivers doing work like this in different > functions? > > Please try to copy the same structure and function name conventions as > other drivers. This applies to all the functions here. It makes > maintenance much easier if code doing similar things looks similar. >
Sure thing. I can use the patterns for the callback functions as they are the ones shared between all drivers.
Thanks, Mani
| |