lkml.org 
[lkml]   [2021]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.10 048/125] firmware: arm_scmi: Fix the build when CONFIG_MAILBOX is not selected
    Date
    From: Sudeep Holla <sudeep.holla@arm.com>

    [ Upstream commit ab7766b72855e6a68109b915d071181b93086e29 ]

    0day CI kernel test robot reported following build error with randconfig

    aarch64-linux-ld: drivers/firmware/arm_scmi/driver.o:(.rodata+0x1e0):
    undefined reference to `scmi_mailbox_desc'

    Fix the error by adding CONFIG_MAILBOX dependency for scmi_mailbox_desc.

    Link: https://lore.kernel.org/r/20210603072631.1660963-1-sudeep.holla@arm.com
    Cc: Etienne Carriere <etienne.carriere@linaro.org>
    Cc: Cristian Marussi <cristian.marussi@arm.com>
    Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org>
    Reviewed-by: Cristian Marussi <cristian.marussi@arm.com>
    Tested-by: Cristian Marussi <cristian.marussi@arm.com>
    Reported-by: kernel test robot <lkp@intel.com>
    Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/firmware/arm_scmi/driver.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
    index f9901fadb3a4..af4560dab6b4 100644
    --- a/drivers/firmware/arm_scmi/driver.c
    +++ b/drivers/firmware/arm_scmi/driver.c
    @@ -922,7 +922,9 @@ ATTRIBUTE_GROUPS(versions);

    /* Each compatible listed below must have descriptor associated with it */
    static const struct of_device_id scmi_of_match[] = {
    +#ifdef CONFIG_MAILBOX
    { .compatible = "arm,scmi", .data = &scmi_mailbox_desc },
    +#endif
    #ifdef CONFIG_HAVE_ARM_SMCCC_DISCOVERY
    { .compatible = "arm,scmi-smc", .data = &scmi_smc_desc},
    #endif
    --
    2.30.2


    \
     
     \ /
      Last update: 2021-07-22 19:34    [W:4.776 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site