lkml.org 
[lkml]   [2021]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 17/23] iommu/vt-d: Prepare for multiple DMA domain types
From
Date
On 2021-07-22 17:44, kernel test robot wrote:
> Hi Robin,
>
> I love your patch! Yet something to improve:
>
> [auto build test ERROR on iommu/next]
> [also build test ERROR on rockchip/for-next linus/master v5.14-rc2 next-20210722]
> [cannot apply to sunxi/sunxi/for-next]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch]
>
> url: https://github.com/0day-ci/linux/commits/Robin-Murphy/iommu-Refactor-DMA-domain-strictness/20210722-022514
> base: https://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git next
> config: ia64-allmodconfig (attached as .config)
> compiler: ia64-linux-gcc (GCC) 10.3.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/0day-ci/linux/commit/c05e0e1856b394eff1167c00f7bbd6ac7cc9dea6
> git remote add linux-review https://github.com/0day-ci/linux
> git fetch --no-tags linux-review Robin-Murphy/iommu-Refactor-DMA-domain-strictness/20210722-022514
> git checkout c05e0e1856b394eff1167c00f7bbd6ac7cc9dea6
> # save the attached .config to linux build tree
> mkdir build_dir
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=ia64 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from arch/ia64/include/asm/bug.h:17,
> from include/linux/bug.h:5,
> from include/linux/thread_info.h:13,
> from include/asm-generic/preempt.h:5,
> from ./arch/ia64/include/generated/asm/preempt.h:1,
> from include/linux/preempt.h:78,
> from include/linux/spinlock.h:51,
> from include/linux/wait.h:9,
> from include/linux/wait_bit.h:8,
> from include/linux/fs.h:6,
> from include/linux/debugfs.h:15,
> from drivers/iommu/intel/iommu.c:18:
> drivers/iommu/intel/iommu.c: In function 'domain_get_iommu':
>>> drivers/iommu/intel/iommu.c:604:38: error: '__IOMMU_DOMAIN_DMA' undeclared (first use in this function); did you mean 'IOMMU_DOMAIN_DMA'?
> 604 | if (WARN_ON(!(domain->domain.type & __IOMMU_DOMAIN_DMA)))
> | ^~~~~~~~~~~~~~~~~~
> include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> 121 | int __ret_warn_on = !!(condition); \
> | ^~~~~~~~~
> drivers/iommu/intel/iommu.c:604:38: note: each undeclared identifier is reported only once for each function it appears in
> 604 | if (WARN_ON(!(domain->domain.type & __IOMMU_DOMAIN_DMA)))
> | ^~~~~~~~~~~~~~~~~~
> include/asm-generic/bug.h:121:25: note: in definition of macro 'WARN_ON'
> 121 | int __ret_warn_on = !!(condition); \
> | ^~~~~~~~~
>
>
> vim +604 drivers/iommu/intel/iommu.c
>
> 597
> 598 /* This functionin only returns single iommu in a domain */
> 599 struct intel_iommu *domain_get_iommu(struct dmar_domain *domain)
> 600 {
> 601 int iommu_id;
> 602
> 603 /* si_domain and vm domain should not get here. */
> > 604 if (WARN_ON(!(domain->domain.type & __IOMMU_DOMAIN_DMA)))

Bleh, of course that should be __IOMMU_DOMAIN_DMA_API like the other two
instances. I'll fix this locally ready for v2.

Thanks,
Robin.

> 605 return NULL;
> 606
> 607 for_each_domain_iommu(iommu_id, domain)
> 608 break;
> 609
> 610 if (iommu_id < 0 || iommu_id >= g_num_of_iommus)
> 611 return NULL;
> 612
> 613 return g_iommus[iommu_id];
> 614 }
> 615
>
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
>
>
> _______________________________________________
> iommu mailing list
> iommu@lists.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
>

\
 
 \ /
  Last update: 2021-07-22 19:31    [W:0.070 / U:1.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site