Messages in this thread | | | From | Jagan Teki <> | Date | Thu, 22 Jul 2021 13:23:53 +0530 | Subject | Re: [PATCH 05/10] drm/panel: Create attach and detach callbacks |
| |
Hi Maxime,
On Tue, Jul 20, 2021 at 7:15 PM Maxime Ripard <maxime@cerno.tech> wrote: > > In order to make the probe order expectation more consistent between > bridges, let's create attach and detach hooks for the panels as well to > match what is there for bridges. > > Signed-off-by: Maxime Ripard <maxime@cerno.tech> > --- > drivers/gpu/drm/drm_panel.c | 20 ++++++++++++++++++++ > include/drm/drm_panel.h | 6 ++++++ > 2 files changed, 26 insertions(+) > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index f634371c717a..23bca798a2f3 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -223,6 +223,26 @@ int drm_panel_get_modes(struct drm_panel *panel, > } > EXPORT_SYMBOL(drm_panel_get_modes); > > +int drm_panel_attach(struct drm_panel *panel) > +{ > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->attach) > + return panel->funcs->attach(panel); > + > + return -EOPNOTSUPP;
Most of the panel drivers won't require panel attach/detach API's so we need to handle those cases as well if we didn't already.
Thanks, Jagan.
| |