lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] tracing/histogram: Rename "cpu" to "common_cpu"
From
Date
Hi Steve,

On Wed, 2021-07-21 at 11:00 -0400, Steven Rostedt wrote:
> From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
>
> Currently the histogram logic allows the user to write "cpu" in as an
> event field, and it will record the CPU that the event happened on.
>
> The problem with this is that there's a lot of events that have "cpu"
> as a real field, and using "cpu" as the CPU it ran on, makes it
> impossible to run histograms on the "cpu" field of events.
>

Yes, you're absolutely right, it should have been named "common_cpu"
from the start, not only for this reason but also just for the sake of
consistency.

Reviewed-by: Tom Zanussi <zanussi@kernel.org>


\
 
 \ /
  Last update: 2021-07-21 22:20    [W:0.399 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site