Messages in this thread | | | Subject | Re: [PATCH v3] tracing/histogram: Rename "cpu" to "common_cpu" | From | Tom Zanussi <> | Date | Wed, 21 Jul 2021 15:19:00 -0500 |
| |
Hi Steve,
On Wed, 2021-07-21 at 11:00 -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org> > > Currently the histogram logic allows the user to write "cpu" in as an > event field, and it will record the CPU that the event happened on. > > The problem with this is that there's a lot of events that have "cpu" > as a real field, and using "cpu" as the CPU it ran on, makes it > impossible to run histograms on the "cpu" field of events. >
Yes, you're absolutely right, it should have been named "common_cpu" from the start, not only for this reason but also just for the sake of consistency.
Reviewed-by: Tom Zanussi <zanussi@kernel.org>
| |