lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH rdma-next 7/7] RDMA/core: Create clean QP creations interface for uverbs
> +struct ib_qp *ib_create_qp_user(struct ib_device *dev, struct ib_pd *pd,
> + struct ib_qp_init_attr *attr,
> + struct ib_udata *udata,
> + struct ib_uqp_object *uobj, const char *caller);
> +static inline struct ib_qp *ib_create_qp_uverbs(struct ib_device *dev,
> + struct ib_pd *pd,
> + struct ib_qp_init_attr *attr,
> + struct ib_udata *udata,
> + struct ib_uqp_object *uobj)
> +{
> + if (attr->qp_type == IB_QPT_XRC_TGT)
> + return ib_create_qp_user(dev, pd, attr, NULL, uobj,
> + KBUILD_MODNAME);
> +
> + return ib_create_qp_user(dev, pd, attr, udata, uobj, NULL);

Why not always pass along the udata and caller and just not use them
in the low-level code?

\
 
 \ /
  Last update: 2021-07-21 08:51    [W:1.324 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site