Messages in this thread | | | Date | Wed, 21 Jul 2021 22:28:33 +0530 | From | Sibi Sankar <> | Subject | Re: [PATCH v4 02/13] dt-bindings: remoteproc: qcom: pas: Add QMP property |
| |
Hey Matthias,
Thanks for taking time to review the series.
On 2021-07-21 04:40, Matthias Kaehlcke wrote: > On Tue, Jul 20, 2021 at 10:06:36AM +0530, Sibi Sankar wrote: >> The load state power-domain, used by the co-processors to notify the >> Always on Subsystem (AOSS) that a particular co-processor is up/down, >> suffers from the side-effect of changing states during suspend/resume. >> However the co-processors enter low-power modes independent to that of >> the application processor and their states are expected to remain >> unaltered across system suspend/resume cycles. To achieve this >> behavior >> let's drop the load state power-domain and replace them with the qmp >> property for all SoCs supporting low power mode signalling. >> >> Signed-off-by: Sibi Sankar <sibis@codeaurora.org> >> --- >> >> v4: >> * Commit message change and sc8180x co-processor addition. >> [Rob/Bjorn] >> >> .../devicetree/bindings/remoteproc/qcom,adsp.yaml | 65 >> +++++++++++----------- >> 1 file changed, 33 insertions(+), 32 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> index c597ccced623..1182afb5f593 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml >> @@ -78,11 +78,11 @@ properties: >> >> power-domains: >> minItems: 1 >> - maxItems: 3 >> + maxItems: 2 >> >> power-domain-names: >> minItems: 1 >> - maxItems: 3 >> + maxItems: 2 > > It seems maxItems should have been 4 in the first place and should > remain > unchanged after removing the load state power domain. With this patch:
sc7180-mpss-pas actually uses only cx and mss. The mpss-pas compatible is overridden by the mss-pil compatible for all the platforms present upstream for sc7180, that's the reason we probably haven't run into any binding check failures. I'll keep the max-items to 2 and fix-up the sc7180 power-domain requirements instead.
> > - if: > properties: > compatible: > contains: > enum: > - qcom,sc7180-mpss-pas > then: > properties: > power-domains: > items: > - description: CX power domain > - description: MX power domain > - description: MSS power domain > power-domain-names: > items: > - const: cx > - const: mx > - const: mss
-- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
| |