lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] ionic: drop useless check of PCI driver data validity
From
Date
On 7/21/21 2:54 AM, Leon Romanovsky wrote:
> From: Leon Romanovsky <leonro@nvidia.com>
>
> The driver core will call to .remove callback only if .probe succeeded
> and it will ensure that driver data has pointer to struct ionic.
>
> There is no need to check it again.
>
> Fixes: fbfb8031533c ("ionic: Add hardware init and device commands")
> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>

Thanks,

Acked-by: Shannon Nelson <snelson@pensando.io>

> ---
> drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> index e4a5416adc80..505f605fa40b 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_bus_pci.c
> @@ -373,9 +373,6 @@ static void ionic_remove(struct pci_dev *pdev)
> {
> struct ionic *ionic = pci_get_drvdata(pdev);
>
> - if (!ionic)
> - return;
> -
> del_timer_sync(&ionic->watchdog_timer);
>
> if (ionic->lif) {

\
 
 \ /
  Last update: 2021-07-21 17:55    [W:0.052 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site