lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: rcar_drif: select CONFIG_V4L2_ASYNC
Hi Arnd,

On 2021-07-21 17:24:59 +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this, I see a randconfig link failure:
>
> aarch64-linux-ld: drivers/media/platform/rcar_drif.o: in function `rcar_drif_remove':
> rcar_drif.c:(.text+0x2a8): undefined reference to `v4l2_async_notifier_unregister'
> aarch64-linux-ld: rcar_drif.c:(.text+0x2b0): undefined reference to `v4l2_async_notifier_cleanup'
> aarch64-linux-ld: drivers/media/platform/rcar_drif.o: in function `rcar_drif_sdr_probe':
> rcar_drif.c:(.text+0x1444): undefined reference to `v4l2_async_notifier_init'
> aarch64-linux-ld: rcar_drif.c:(.text+0x14a0): undefined reference to `v4l2_async_notifier_register'
> aarch64-linux-ld: rcar_drif.c:(.text+0x14d8): undefined reference to `v4l2_async_notifier_cleanup'
> aarch64-linux-ld: rcar_drif.c:(.text+0x15a8): undefined reference to `__v4l2_async_notifier_add_fwnode_subdev'
>
> I could not easily figure out when this was introduced, as this code
> has not changed in a while but I only saw the problem recently.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> drivers/media/platform/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 157c924686e4..c5d1c83bd582 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -635,6 +635,7 @@ config VIDEO_RCAR_DRIF
> depends on VIDEO_V4L2
> depends on ARCH_RENESAS || COMPILE_TEST
> select VIDEOBUF2_VMALLOC
> + select V4L2_ASYNC
> help
> Say Y if you want to enable R-Car Gen3 DRIF support. DRIF is Digital
> Radio Interface that interfaces with an RF front end chip. It is a
> --
> 2.29.2
>

--
Regards,
Niklas Söderlund

\
 
 \ /
  Last update: 2021-07-21 17:31    [W:0.037 / U:1.684 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site