Messages in this thread | | | Date | Wed, 21 Jul 2021 23:25:50 +0800 | From | kernel test robot <> | Subject | Re: [net,v6] net: stmmac: fix 'ethtool -P' return -EBUSY |
| |
Hi Hao,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master] [also build test ERROR on v5.14-rc2 next-20210721] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hao-Chen/net-stmmac-fix-ethtool-P-return-EBUSY/20210721-172413 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 8cae8cd89f05f6de223d63e6d15e31c8ba9cf53b config: nios2-allyesconfig (attached as .config) compiler: nios2-linux-gcc (GCC) 10.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/0day-ci/linux/commit/c55b4adeb427ae7db9fb2942a7bc7958a8d667bd git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Hao-Chen/net-stmmac-fix-ethtool-P-return-EBUSY/20210721-172413 git checkout c55b4adeb427ae7db9fb2942a7bc7958a8d667bd # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c: In function 'stmmac_ethtool_begin': >> drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:418:35: error: passing argument 1 of 'pm_runtime_resume_and_get' from incompatible pointer type [-Werror=incompatible-pointer-types] 418 | return pm_runtime_resume_and_get(dev); | ^~~ | | | struct net_device * In file included from drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:17: include/linux/pm_runtime.h:400:60: note: expected 'struct device *' but argument is of type 'struct net_device *' 400 | static inline int pm_runtime_resume_and_get(struct device *dev) | ~~~~~~~~~~~~~~~^~~ drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:416:22: warning: unused variable 'priv' [-Wunused-variable] 416 | struct stmmac_priv *priv = netdev_priv(dev); | ^~~~ cc1: some warnings being treated as errors
vim +/pm_runtime_resume_and_get +418 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
413 414 static int stmmac_ethtool_begin(struct net_device *dev) 415 { 416 struct stmmac_priv *priv = netdev_priv(dev); 417 > 418 return pm_runtime_resume_and_get(dev); 419 } 420
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |