lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] checkpatch: add grammatical judgement for total output
Date
There lacked a English grammatical identification within the final
output of checkpatch.pl such as the following:

total: 1 errors, 11 warnings, 4094 lines checked
^

Which violated the rule about the usage of the singular form and the
plural form. Hence fix the issue up and make it output the proper
sentence.

Signed-off-by: Hu Haowen <src.res@email.cn>
---
scripts/checkpatch.pl | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 461d4221e4a4..eec96ed95262 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -7439,9 +7439,14 @@ sub process {
print report_dump();
if ($summary && !($clean == 1 && $quiet == 1)) {
print "$filename " if ($summary_file);
- print "total: $cnt_error errors, $cnt_warn warnings, " .
- (($check)? "$cnt_chk checks, " : "") .
- "$cnt_lines lines checked\n";
+ my $errors_str = ($cnt_error == 1) ? "error" : "errors";
+ my $warnings_str = ($cnt_warn == 1) ? "warning" : "warnings";
+ my $checks_str = ($cnt_chk == 1) ? "check" : "checks";
+ my $lines_str = ($cnt_lines == 1) ? "line" : "lines";
+ print "total: $cnt_error $errors_str, " .
+ "$cnt_warn $warnings_str, " .
+ (($check)? "$cnt_chk $checks_str, " : "") .
+ "$cnt_lines $lines_str checked\n";
}

if ($quiet == 0) {
--
2.25.1
\
 
 \ /
  Last update: 2021-07-21 17:15    [W:0.041 / U:1.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site