Messages in this thread | | | Date | Wed, 21 Jul 2021 16:34:56 +0200 | From | Johan Hovold <> | Subject | Re: [PATCH v3 1/2] usb: hso: fix error handling code of hso_create_net_device |
| |
On Wed, Jul 21, 2021 at 04:17:01PM +0800, Dongliang Mu wrote: > On Wed, Jul 21, 2021 at 3:36 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > On Wed, Jul 14, 2021 at 05:13:22PM +0800, Dongliang Mu wrote: > > > The current error handling code of hso_create_net_device is > > > hso_free_net_device, no matter which errors lead to. For example, > > > WARNING in hso_free_net_device [1]. > > > > > > Fix this by refactoring the error handling code of > > > hso_create_net_device by handling different errors by different code. > > > > > > [1] https://syzkaller.appspot.com/bug?id=66eff8d49af1b28370ad342787413e35bbe76efe > > > > > > Reported-by: syzbot+44d53c7255bb1aea22d2@syzkaller.appspotmail.com > > > Fixes: 5fcfb6d0bfcd ("hso: fix bailout in error case of probe") > > > Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> > > > --- > > > v1->v2: change labels according to the comment of Dan Carpenter > > > v2->v3: change the style of error handling labels > > > drivers/net/usb/hso.c | 33 +++++++++++++++++++++++---------- > > > 1 file changed, 23 insertions(+), 10 deletions(-) > > > > Please resend the whole series, not just one patch of the series. > > Otherwise it makes it impossible to determine what patch from what > > series should be applied in what order. > > > > Done. Please review the resend v3 patches. > > > All of these are now dropped from my queue, please fix up and resend.
A version of this patch has already been applied to net-next.
No idea which version that was or why the second patch hasn't been applied yet.
Dongliang, if you're resending something here it should first be rebased on linux-next (net-next).
Johan
| |