| From | Arnd Bergmann <> | Date | Wed, 21 Jul 2021 13:55:07 +0200 | Subject | Re: [PATCH v7 11/10] PCI: kirin: Allow building it as a module |
| |
On Wed, Jul 21, 2021 at 12:15 PM Mauro Carvalho Chehab <mchehab+huawei@kernel.org> wrote: > > There's nothing preventing this driver to be loaded as a > module. So, change its config from bool to tristate. > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
No objections from me, but I wonder if you would also consider making the module removable. It's currently marked as 'builtin_platform_driver', so you can load but not remove it. Rob has done some bug fixes that make it possible to remove similar drivers, so it's probably not much work here either.
Arnd
|