Messages in this thread | | | Date | Wed, 21 Jul 2021 13:54:15 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] firmware: QCOM_SCM: Allow qcom_scm driver to be loadable as a permenent module |
| |
On Wed, Jul 07, 2021 at 04:53:20AM +0000, John Stultz wrote: > Allow the qcom_scm driver to be loadable as a permenent module.
This feels like a regression, it should be allowed to be a module.
> This still uses the "depends on QCOM_SCM || !QCOM_SCM" bit to > ensure that drivers that call into the qcom_scm driver are > also built as modules. While not ideal in some cases its the > only safe way I can find to avoid build errors without having > those drivers select QCOM_SCM and have to force it on (as > QCOM_SCM=n can be valid for those drivers). > > Reviving this now that Saravana's fw_devlink defaults to on, > which should avoid loading troubles seen before.
fw_devlink was supposed to resolve these issues and _allow_ code to be built as modules and not forced to be built into the kernel.
Let's not go backwards please.
thanks,
greg k-h
| |