lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] staging: rtl8188eu: Remove an unused variable and some lines of code
    Date
    On Wednesday, July 21, 2021 10:19:33 AM CEST Greg Kroah-Hartman wrote:
    > On Mon, Jul 05, 2021 at 03:41:51PM +0200, Fabio M. De Francesco wrote:
    > > Remove set but unused iw_operation_mode[]. This driver doesn't support
    > > SIOCSIWRATE. It just returns zero and does nothing. Change it to
    > > return -ENOTSUPP instead. (This is an API change but we don't expect it
    > > to break anything).
    > >
    > > Suggested-by: Dan Carpenter <dan.carpenter@oracle.com>
    > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
    > > ---
    > >
    > > v1->v2: Delete rtw_wx_set_rate() and its association with command
    > > SIOCSIWRATE as suggested by Dan Carpenter <dan.carpenter@oracle.com>
    >
    > Does not apply to my tree :(
    >
    Hi Greg,

    It cannot apply to your tree because, while it was waiting for acceptance,
    someone else did a large part of the removal of the code related to the
    unsupported SIOCSIWRATE and you applied this other patch.

    However, the no more necessary iw_operation_mode[] is still in your tree. So
    I'm about to send a patch that only removes the above-mentioned array.

    Thanks,

    Fabio



    \
     
     \ /
      Last update: 2021-07-21 13:44    [W:4.000 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site