Messages in this thread | | | Date | Wed, 21 Jul 2021 12:22:39 +0200 | From | Greg KH <> | Subject | Re: [PATCH v4] tty: n_gsm: delete DISC command frame as requester |
| |
On Mon, Jul 05, 2021 at 07:59:42PM +0800, Zhenguo Zhao wrote: > From: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com> > > as initiator,it need to send DISC command ,as requester,there is > no need to send the DISC control frame,it will cause redundant data.
I am really sorry, but I can not understand what the problem is here, nor what you are saying is being changed.
Can you try to resend this with a more expanded changelog text? Perhaps get someone else to help out with the wording?
> > Signed-off-by: Zhenguo Zhao <Zhenguo.Zhao1@unisoc.com> > --- > drivers/tty/n_gsm.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c > index 5fea02c..ea9c750 100644 > --- a/drivers/tty/n_gsm.c > +++ b/drivers/tty/n_gsm.c > @@ -2050,7 +2050,8 @@ static int gsm_disconnect(struct gsm_mux *gsm) > del_timer_sync(&gsm->t2_timer); > /* Now we are sure T2 has stopped */ > > - gsm_dlci_begin_close(dlci); > + if (gsm->initiator) > + gsm_dlci_begin_close(dlci); > wait_event_interruptible(gsm->event, > dlci->state == DLCI_CLOSED); > > @@ -3024,7 +3025,8 @@ static void gsmtty_close(struct tty_struct *tty, struct file *filp) > mutex_unlock(&dlci->mutex); > if (tty_port_close_start(&dlci->port, tty, filp) == 0) > return; > - gsm_dlci_begin_close(dlci); > + if (dlci->gsm->initiator) > + gsm_dlci_begin_close(dlci); > if (tty_port_initialized(&dlci->port) && C_HUPCL(tty)) > tty_port_lower_dtr_rts(&dlci->port); > tty_port_close_end(&dlci->port, tty); > @@ -3035,10 +3037,12 @@ static void gsmtty_close(struct tty_struct *tty, struct file *filp) > static void gsmtty_hangup(struct tty_struct *tty) > { > struct gsm_dlci *dlci = tty->driver_data; > + struct gsm_mux *gsm = dlci->gsm; > if (dlci->state == DLCI_CLOSED)
You have a coding style issue here now, so I can't take this anyway :(
thanks,
greg k-h
| |