Messages in this thread | | | Subject | Re: [PATCH] dt-bindings: Remove "status" from schema examples | From | Philipp Zabel <> | Date | Wed, 21 Jul 2021 10:32:58 +0200 |
| |
Hi Rob,
On Tue, 2021-07-20 at 11:20 -0600, Rob Herring wrote: > There's no reason to have "status" properties in examples. "okay" is the > default, and "disabled" turns off some schema checks ('required' > specifically).
Is this documented somewhere? If not, should it be? (Maybe in writing- schema.rst -> Schema Contents -> examples?)
> Enabling qca,ar71xx causes a warning, so let's fix the node names: > > Documentation/devicetree/bindings/net/qca,ar71xx.example.dt.yaml: phy@3: '#phy-cells' is a required property > From schema: schemas/phy/phy-provider.yaml > > Cc: Maxime Ripard <mripard@kernel.org> > Cc: Chen-Yu Tsai <wens@csie.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Sam Ravnborg <sam@ravnborg.org> > Cc: Rui Miguel Silva <rmfrfs@gmail.com> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Jakub Kicinski <kuba@kernel.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Robert Marko <robert.marko@sartura.hr> > Cc: Philipp Zabel <p.zabel@pengutronix.de> > Cc: Alessandro Zummo <a.zummo@towertech.it> > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > Cc: Ramesh Shanmugasundaram <rashanmu@gmail.com> > Cc: "G. Jaya Kumaran" <vineetha.g.jaya.kumaran@intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Oleksij Rempel <o.rempel@pengutronix.de> > Cc: ChiYuan Huang <cy_huang@richtek.com> > Cc: Wei Xu <xuwei5@hisilicon.com> > Cc: Dilip Kota <eswara.kota@linux.intel.com> > Cc: Karol Gugala <kgugala@antmicro.com> > Cc: Mateusz Holenko <mholenko@antmicro.com> > Cc: Olivier Moysan <olivier.moysan@st.com> > Cc: Peter Ujfalusi <peter.ujfalusi@ti.com> > Cc: dri-devel@lists.freedesktop.org > Cc: linux-media@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-rtc@vger.kernel.org > Cc: alsa-devel@alsa-project.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../display/allwinner,sun8i-a83t-dw-hdmi.yaml | 2 -- > .../display/panel/boe,tv101wum-nl6.yaml | 1 - > .../bindings/media/nxp,imx7-mipi-csi2.yaml | 2 -- > .../bindings/media/renesas,drif.yaml | 1 - > .../bindings/net/intel,dwmac-plat.yaml | 2 -- > .../bindings/net/intel,ixp4xx-ethernet.yaml | 2 -- > .../bindings/net/nfc/samsung,s3fwrn5.yaml | 3 --- > .../devicetree/bindings/net/qca,ar71xx.yaml | 25 ++++--------------- > .../regulator/richtek,rt6245-regulator.yaml | 1 - > .../regulator/vqmmc-ipq4019-regulator.yaml | 1 - > .../reset/hisilicon,hi3660-reset.yaml | 1 - > .../bindings/reset/intel,rcu-gw.yaml | 1 - [...]
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards Philipp
| |