Messages in this thread | | | Subject | Re: [PATCH] block/bfq: the delta_from_first should be ns rather than us | From | Paolo Valente <> | Date | Wed, 21 Jul 2021 09:56:12 +0200 |
| |
[RESENDING ...]
> Il giorno 21 lug 2021, alle ore 08:30, liubaozhu <liubaozhu@uniontech.com> ha scritto: > > In the block/bfq-iosched.c,the function bfq_update_peak_rate(), > bfqd->delta_from_first = now_ns - bfqd->first_dispatch, > according to the subtraction operation here,now_ns is ns, > and bfqd->first_dispatch is also ns,so bfqd->delta_from_first should be ns. >
Correct!
Acked-by: Paolo Valente <paolo.valente@linaro.org>
Thank you, Paolo
> Signed-off-by: liubaozhu <liubaozhu@uniontech.com> > --- > block/bfq-iosched.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h > index 99c2a3cb0..7cf4fc8c3 100644 > --- a/block/bfq-iosched.h > +++ b/block/bfq-iosched.h > @@ -632,7 +632,7 @@ struct bfq_data { > u64 tot_sectors_dispatched; > /* max rq size seen during current observation interval (sectors) */ > u32 last_rq_max_size; > - /* time elapsed from first dispatch in current observ. interval (us) */ > + /* time elapsed from first dispatch in current observ. interval (ns) */ > u64 delta_from_first; > /* > * Current estimate of the device peak rate, measured in > -- > 2.20.1 > > >
| |