Messages in this thread | | | From | Krzysztof Hałasa <> | Subject | Re: [PATCH REPOST] TDA1997x: replace video detection routine | Date | Wed, 21 Jul 2021 09:56:05 +0200 |
| |
Hi Hans,
Hans Verkuil <hverkuil@xs4all.nl> writes:
>> --- a/drivers/media/i2c/tda1997x.c >> +++ b/drivers/media/i2c/tda1997x.c >> @@ -1092,66 +1094,71 @@ tda1997x_detect_std(struct tda1997x_state *state, >> struct v4l2_dv_timings *timings)
...
>> + if (!timings) >> + return 0; > > This check isn't necessary, timings is never NULL.
Well, the tda1997x_irq_sus() does this:
if (debug) tda1997x_detect_std(state, NULL);
Perhaps there is a better way, but I think I will leave it for now. Also there is the issue of ignoring tda1997x_detect_std() return value, but I can now see it's only a case in tda1997x_query_dv_timings(), easy to fix.
Will post an update shortly.
Thanks for your comments, -- Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz Przemysłowy Instytut Automatyki i Pomiarów PIAP Al. Jerozolimskie 202, 02-486 Warszawa
| |