lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH rdma-next 7/7] RDMA/core: Create clean QP creations interface for uverbs
On Wed, Jul 21, 2021 at 08:12:35AM +0100, Christoph Hellwig wrote:
> On Wed, Jul 21, 2021 at 10:06:06AM +0300, Leon Romanovsky wrote:
> > You will need to add some sort of "if qp tpye" for ib_create_qp_uverbs() callers,
> > because they always provide udata != NULL.
> >
> > After this series, the callers look like this:
> >
> > 1438 qp = ib_create_qp_uverbs(device, pd, &attr, &attrs->driver_udata, obj);
> > ^^^^^^^^^ not NULL
> >
> > So instead of bothering callers, I implemented it here with one "if".
>
> Sorry if my mail was confusing. I don't want it in the callers, I
> want it as deep down in the stack as possible instead of having the
> strange wrapper.

I see, will change and resend.

Thanks

\
 
 \ /
  Last update: 2021-07-21 09:33    [W:0.426 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site