lkml.org 
[lkml]   [2021]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH kcsan 2/8] kcsan: Remove CONFIG_KCSAN_DEBUG
    Date
    From: Marco Elver <elver@google.com>

    By this point CONFIG_KCSAN_DEBUG is pretty useless, as the system just
    isn't usable with it due to spamming console (I imagine a randconfig
    test robot will run into this sooner or later). Remove it.

    Back in 2019 I used it occasionally to record traces of watchpoints and
    verify the encoding is correct, but these days we have proper tests. If
    something similar is needed in future, just add it back ad-hoc.

    Signed-off-by: Marco Elver <elver@google.com>
    Acked-by: Mark Rutland <mark.rutland@arm.com>
    Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
    ---
    kernel/kcsan/core.c | 9 ---------
    lib/Kconfig.kcsan | 3 ---
    2 files changed, 12 deletions(-)

    diff --git a/kernel/kcsan/core.c b/kernel/kcsan/core.c
    index 26709ea65c715..d92977ede7e17 100644
    --- a/kernel/kcsan/core.c
    +++ b/kernel/kcsan/core.c
    @@ -479,15 +479,6 @@ kcsan_setup_watchpoint(const volatile void *ptr, size_t size, int type)
    break; /* ignore; we do not diff the values */
    }

    - if (IS_ENABLED(CONFIG_KCSAN_DEBUG)) {
    - kcsan_disable_current();
    - pr_err("watching %s, size: %zu, addr: %px [slot: %d, encoded: %lx]\n",
    - is_write ? "write" : "read", size, ptr,
    - watchpoint_slot((unsigned long)ptr),
    - encode_watchpoint((unsigned long)ptr, size, is_write));
    - kcsan_enable_current();
    - }
    -
    /*
    * Delay this thread, to increase probability of observing a racy
    * conflicting access.
    diff --git a/lib/Kconfig.kcsan b/lib/Kconfig.kcsan
    index 6152fbd5cbb43..5304f211f81f1 100644
    --- a/lib/Kconfig.kcsan
    +++ b/lib/Kconfig.kcsan
    @@ -62,9 +62,6 @@ config KCSAN_VERBOSE
    generated from any one of them, system stability may suffer due to
    deadlocks or recursion. If in doubt, say N.

    -config KCSAN_DEBUG
    - bool "Debugging of KCSAN internals"
    -
    config KCSAN_SELFTEST
    bool "Perform short selftests on boot"
    default y
    --
    2.31.1.189.g2e36527f23
    \
     
     \ /
      Last update: 2021-07-21 23:10    [W:4.165 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site