lkml.org 
[lkml]   [2021]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2 3/4] arm64: do not use dummy vcpu_is_preempted()
On (21/07/12 16:47), Marc Zyngier wrote:
> > #include <asm/qspinlock.h>
> > #include <asm/qrwlock.h>
> > +#include <asm/paravirt.h>
> >
> > /* See include/linux/spinlock.h */
> > #define smp_mb__after_spinlock() smp_mb()
> >
> > -/*
> > - * Changing this will break osq_lock() thanks to the call inside
> > - * smp_cond_load_relaxed().
> > - *
> > - * See:
> > - * https://lore.kernel.org/lkml/20200110100612.GC2827@hirez.programming.kicks-ass.net
> > - */
>
> Why are you deleting this? Please explain your reasoning in the commit
> message. It seems to me that it still makes complete sense when
> CONFIG_PARAVIRT is not defined.

You are right. I'll move it to !PARAVIRT #else-branch.

\
 
 \ /
  Last update: 2021-07-21 04:08    [W:0.056 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site