Messages in this thread | | | From | "Qin, Chao" <> | Subject | RE: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush() | Date | Wed, 21 Jul 2021 01:42:23 +0000 |
| |
Noted. Thanks for your review.
-Chao.
-----Original Message----- From: John Ogness <john.ogness@linutronix.de> Sent: Tuesday, July 20, 2021 10:03 PM To: Joe Perches <joe@perches.com>; Qin, Chao <chao.qin@intel.com>; linux-kernel@vger.kernel.org; linux-rt-users@vger.kernel.org; bigeasy@linutronix.de; tglx@linutronix.de; rostedt@goodmis.org Cc: mgross@linux.intel.com; Mei, Paul <paul.mei@intel.com>; Li, Lili <lili.li@intel.com> Subject: Re: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush()
On 2021-07-20, Joe Perches <joe@perches.com> wrote: > Logic continuations are typically at the end of the previous line. > And there are few too many parentheses for my taste. > > Maybe exceed 80 columns in a single line > > may_sleep = preemptible() && !in_softirq() && system_state >= > SYSTEM_RUNNING; > > or align the continuation > > may_sleep = (preemptible() && !in_softirq() && > system_state >= SYSTEM_RUNNING); > > or use individual lines > > may_sleep = (preemptible() && > !in_softirq() && > system_state >= SYSTEM_RUNNING);
The kernel now has a 100-column policy, but I decided to go with this third variant for easy reading.
Chao Qin, your patch will be part of the next PREEMPT_RT release. Thank you.
John Ogness
| |